Closed
Conversation
…wn_to_round_function
…jorgsowa/php-src into add_modes_up_and_down_to_round_function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces fours new modes to the
round()function:PHP_ROUND_UP,PHP_ROUND_DOWN,PHP_AWAY_FROM_ZEROandPHP_TOWARD_ZERO.Those four modes are frequently used in accounting and are heavily requested by the PHP users. Two first comments in
round()documentation page is about this feature and how can it currently be achieved in the userland. However if we already have 4 existing modes it's not big effort to implement next four modes which are more popular than existingPHP_ROUND_HALF_EVENandPHP_ROUND_HALF_ODDand in fact completing all of the most popular rounding modes.Performance for the default mode (PHP_ROUND_HALF_UP) for the function
round()in my version is a little bit slower than in current version. I am not sure how can I speed it up, because by the code, it costs the same amount of time.