This repository was archived by the owner on Jun 24, 2020. It is now read-only.
We need to fail the install if any transforms error#212
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Nov 12, 2019
Merged
We need to fail the install if any transforms error#212knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
Otherwise, the operator will keep retrying indefinitely, but the status of the KS CR will continue to show Ready. Also removing redundant updateStatus call since we're already calling it in the reconcile loop.
houshengbo
reviewed
Nov 12, 2019
| // Check for all deployments available | ||
| func (r *Reconciler) checkDeployments(manifest *mf.Manifest, instance *servingv1alpha1.KnativeServing) error { | ||
| r.Logger.Debug("Checking deployments") | ||
| defer r.updateStatus(instance) |
There was a problem hiding this comment.
@jcrossley3 Has this line intentionally been removed?
Contributor
Author
There was a problem hiding this comment.
Yes. I think it's redundant due to
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, jcrossley3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, updating an existing
KnativeServingresource in a way that makes any of the transformations fail will cause the operator to retry indefinitely, but the status of theKnativeServingCR will continue to showReady.