Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Propagating configured imagePullSecrets to the Image#229

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
garron:garron-image-imagepullsecrets
Dec 3, 2019
Merged

Propagating configured imagePullSecrets to the Image#229
knative-prow-robot merged 1 commit intoknative:masterfrom
garron:garron-image-imagepullsecrets

Conversation

@garron
Copy link
Contributor

@garron garron commented Nov 20, 2019 •
edited
Loading

Fixes #221

@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Nov 20, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garron: 0 warnings.

Details

In response to this:

Fixes #220

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

knative-metrics-robot commented Nov 20, 2019

The following is the coverage report on the affected files.
Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeserving/common/images.go 86.2% 86.7% 0.5

houshengbo
houshengbo approved these changes Dec 3, 2019
View reviewed changes
Copy link

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Thank @garron for the fix!

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garron, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ed05127 into knative:master Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

2 more reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@houshengbo houshengbo houshengbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@houshengbo houshengbo

Labels

approved cla: yes Author(s) signed a CLA. lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Image transformation is still missing the support of private secret

5 participants

@garron @knative-metrics-robot @knative-prow-robot @houshengbo @googlebot