This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Add step to push to github package registry#332
Merged
Conversation
grampelberg
reviewed
Jan 30, 2020
Collaborator
grampelberg
left a comment
grampelberg
left a comment
There was a problem hiding this comment.
I'm kinda meh about doing this until GPR allows for anonymous. It feels like it'll just be confusing until then. The UI isn't setup to handle PR pushes either. WDYT about limiting to release tags?
Collaborator
Author
|
That sounds fine to me. I'm pretty sure this should only run on tags ATM. It would be nice to have some artifacts there once/if they ever "fix" that missing feature. |
Collaborator
|
Oh, we're not actually tagging images correctly yet are we? It'd be nice to have the image tags match the release/repo tags. Maybe we should do that first? |
Collaborator
Author
|
Yeah IIRC we haven't been doing that, just the git sha to match with. Easy to update for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just because why not. We may use it eventually.