fix: switch to official phpmyadmin Docker image by AaronFeledy · Pull Request #74 · lando/phpmyadmin

AaronFeledy · 2026-02-22T20:41:49Z

Switches from the deprecated phpmyadmin/phpmyadmin Docker image to the official phpmyadmin image.

The deprecated image only has amd64 builds, while the official image includes arm64 — fixing phpmyadmin on Apple Silicon Macs.

Changes

builders/phpmyadmin.js: phpmyadmin/phpmyadmin:${version} → phpmyadmin:${version}
docs/index.md + docs/config.md: Updated all Docker Hub links to the official image page
CHANGELOG.md: Added unreleased entry

Fixes #61

Note

Medium Risk
Changes the runtime Docker image selection for the phpMyAdmin service and expands CI/example coverage; main risk is behavioral differences between images/tags across versions.

Overview
Switches phpMyAdmin service versions 5.x+ to use the official phpmyadmin:<version> image (keeping phpmyadmin/phpmyadmin for legacy 4.x) to add arm64/Apple Silicon support, and updates docs/changelog links accordingly.

Modernizes CI and examples: bumps workflows to Node 20/Ubuntu 24.04, adds Dependabot coverage for examples/*, pins example DB versions, adds new examples/mysql (plus CI coverage), and updates example plugin dependencies (@lando/mariadb ^1.8.0, @lando/mysql ^1.6.0).

^{Written by Cursor Bugbot for commit 2444aaa. This will update automatically on new commits. Configure here.}

netlify · 2026-02-22T20:41:53Z

✅ Deploy Preview for lando-phpmyadmin ready!

Name	Link
🔨 Latest commit	`2444aaa`
🔍 Latest deploy log	https://app.netlify.com/projects/lando-phpmyadmin/deploys/699b9d71a5db9b0008b5bbce
😎 Deploy Preview	https://deploy-preview-74--lando-phpmyadmin.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 4 from production) Accessibility: 98 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

builders/phpmyadmin.js

AaronFeledy · 2026-02-22T20:46:57Z

@cursor push 7ffeb30

The official phpmyadmin Docker image only has 5.x tags. Legacy 4.x versions (4.9, 4.8, 4.7, 4.6) are only available on the deprecated phpmyadmin/phpmyadmin image. This change uses the appropriate image based on version to prevent Docker pull failures for legacy versions. Applied via @cursor push command

builders/phpmyadmin.js

AaronFeledy · 2026-02-22T20:54:22Z

@cursor push b36bfbd

Change version threshold from 5.0.0 to 5.2.0 to ensure versions 5.0 and 5.1 use the deprecated phpmyadmin/phpmyadmin image where these tags exist, since the official phpmyadmin image only supports 5.2.x and higher. Applied via @cursor push command

builders/phpmyadmin.js

…5.x+)

builders/phpmyadmin.js

AaronFeledy · 2026-02-22T21:56:20Z

@cursor push 3c66926

…g it Applied via @cursor push command

AaronFeledy · 2026-02-22T21:57:21Z

@cursor Make sure all the github actions runners are up to date, including getting things running on node 20

cursor · 2026-02-22T21:57:27Z

I've successfully updated all GitHub Actions workflows to use Node 20 and the latest runner versions:

Updated Workflows:

pr-unit-tests.yml: Node 18 → Node 20
pr-docs-tests.yml: Node 18 → Node 20
pr-linter.yml: Node 18 → Node 20
pr-phpmyadmin-tests.yml: Node 18 → Node 20
label-add-to-project.yml: ubuntu-latest → ubuntu-24.04

Additional Fix:

Removed trailing spaces in builders/phpmyadmin.js (lines 32 and 35) that were causing lint failures

All changes have been committed and pushed to the fix/official-docker-image branch. The release.yml workflow was already using Node 20, so no changes were needed there.

- Update all workflow files to use Node 20 instead of Node 18 - Update label-add-to-project.yml to use ubuntu-24.04 instead of ubuntu-latest - Fix trailing spaces lint errors in builders/phpmyadmin.js Co-authored-by: Aaron Feledy <[email protected]>

The leia tests use mariadb and mysql services but these plugins were missing from package.json. CI runs npm install --production which only installs dependencies, so these need to be regular deps (matching the pattern used by @lando/lamp and other plugins).

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issue.}

package.json

cursor · 2026-02-22T22:08:19Z

Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.

✅ Fixed: Test dependencies incorrectly added as production dependencies
- Moved @lando/mariadb and @lando/mysql from dependencies to devDependencies since they are only used in test examples and not imported in the plugin's source code.

Or push these changes by commenting:

@cursor push 4637de3d1b

Preview (4637de3d1b)

diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -43,14 +43,14 @@
     "test": "npm run lint && npm run test:unit"
   },
   "dependencies": {
-    "@lando/mariadb": "^1.8.0",
-    "@lando/mysql": "^1.6.0",
     "lodash": "^4.17.21",
     "semver": "^7.7.1"
   },
   "devDependencies": {
     "@babel/eslint-parser": "^7.16.0",
     "@lando/leia": "^1.0.0-beta.4",
+    "@lando/mariadb": "^1.8.0",
+    "@lando/mysql": "^1.6.0",
     "@lando/vitepress-theme-default-plus": "^1.1.1",
     "chai": "^4.3.4",
     "command-line-test": "^1.0.10",

- Move @lando/mariadb and @lando/mysql to devDependencies (test-only deps) - Remove --production flag from leia tests CI so devDeps get installed - Fix .lando.yml plugin paths to resolve from repo root node_modules (./../../node_modules/... instead of ./node_modules/...)

The real issue: example dirs have their own package.json + lockfiles. The leia tests run 'npm ci' in each example dir, and the lockfiles had stale @lando/[email protected] (examples/4.x, 5.x) while package.json required ^1.8.0. examples/mysql was missing a lockfile entirely. - Regenerated lockfiles in examples/4.x, 5.x, and mysql - Added missing package-lock.json for examples/mysql - Reverted .lando.yml plugin paths to ./node_modules/ (correct, since npm ci runs in the example dir) - Reverted root package.json and CI workflow (no changes needed there)

- Fix 5.x test: check PMA config file for database hostnames instead of scraping HTML (PMA 5.x doesn't render hostnames in login page HTML) - Add dependabot entries for examples/4.x, 5.x, and mysql directories so their @lando/* deps stay up to date

The config.inc.php reads hostnames from env vars at runtime via PHP - grepping the raw file won't find the hostname strings. Use php -r to require the config and print the resolved server host values.

Consolidate npm directories for examples and group updates.

fix: switch to official phpmyadmin Docker image for arm64 support

b039fa3

cursor bot reviewed Feb 22, 2026

View reviewed changes

builders/phpmyadmin.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

cursor bot reviewed Feb 22, 2026

View reviewed changes

builders/phpmyadmin.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

cursor bot reviewed Feb 22, 2026

View reviewed changes

builders/phpmyadmin.js Outdated Show resolved Hide resolved

AaronFeledy force-pushed the fix/official-docker-image branch from c9ad934 to 77d01c1 Compare February 22, 2026 21:00

fix: simplify image reference and fix lint error

e56a627

AaronFeledy force-pushed the fix/official-docker-image branch from 77d01c1 to e56a627 Compare February 22, 2026 21:00

fix: add hub.docker.com to netlify link checker todoPatterns

0b0efb9

This comment has been minimized.

Sign in to view

AaronFeledy added 5 commits February 22, 2026 15:02

fix: restore correct legacy command threshold to 5.2.0

20418cc

fix: use legacy image for 4.x versions (official image only supports …

65b0b83

…5.x+)

fix: correct legacy threshold to 5.0.0 (official image has 5.0+)

250e46d

test: modernize examples with specific database versions

6c9a9f2

chore: update @lando package deps and changelog

9490c24

cursor bot reviewed Feb 22, 2026

View reviewed changes

builders/phpmyadmin.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Fix duplicated semver comparison by defining isLegacy once and reusin…

d0e97cb

…g it Applied via @cursor push command

cursoragent and others added 2 commits February 22, 2026 21:58

cursor bot reviewed Feb 22, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

AaronFeledy added 5 commits February 22, 2026 16:14

fix: use php to evaluate PMA config for server host test

3b8b1ec

The config.inc.php reads hostnames from env vars at runtime via PHP - grepping the raw file won't find the hostname strings. Use php -r to require the config and print the resolved server host values.

Update dependabot configuration for npm examples

2444aaa

Consolidate npm directories for examples and group updates.

AaronFeledy merged commit 1c85e46 into main Feb 23, 2026
14 checks passed

This was referenced Feb 23, 2026

Phpmyadmin isLegacy duplication #79

Closed

Test dependencies placement #80

Closed

AaronFeledy deleted the fix/official-docker-image branch February 23, 2026 00:33

This was referenced Feb 23, 2026

Phpmyadmin legacy command threshold #78

Closed

Phpmyadmin 4.x image availability #75

Closed

Phpmyadmin image version tags #76

Closed

Conversation

AaronFeledy commented Feb 22, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

netlify bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for lando-phpmyadmin ready!

Uh oh!

Uh oh!

This comment has been minimized.

AaronFeledy commented Feb 22, 2026

Uh oh!

Uh oh!

This comment has been minimized.

AaronFeledy commented Feb 22, 2026

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

AaronFeledy commented Feb 22, 2026

Uh oh!

AaronFeledy commented Feb 22, 2026

Uh oh!

cursor bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot commented Feb 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AaronFeledy commented Feb 22, 2026 •

edited by cursor bot

Loading

netlify bot commented Feb 22, 2026 •

edited

Loading

cursor bot commented Feb 22, 2026 •

edited

Loading