Closed
Conversation
The official phpmyadmin Docker image only has 5.x tags. Legacy 4.x versions (4.9, 4.8, 4.7, 4.6) are only available on the deprecated phpmyadmin/phpmyadmin image. This change uses the appropriate image based on version to prevent Docker pull failures for legacy versions. Applied via @cursor push command
Change version threshold from 5.0.0 to 5.2.0 to ensure versions 5.0 and 5.1 use the deprecated phpmyadmin/phpmyadmin image where these tags exist, since the official phpmyadmin image only supports 5.2.x and higher. Applied via @cursor push command
…g it Applied via @cursor push command
- Update all workflow files to use Node 20 instead of Node 18 - Update label-add-to-project.yml to use ubuntu-24.04 instead of ubuntu-latest - Fix trailing spaces lint errors in builders/phpmyadmin.js Co-authored-by: Aaron Feledy <[email protected]>
The leia tests use mariadb and mysql services but these plugins were missing from package.json. CI runs npm install --production which only installs dependencies, so these need to be regular deps (matching the pattern used by @lando/lamp and other plugins).
These packages are test dependencies used only in examples/, not production dependencies. Moving them prevents unnecessary transitive dependencies for consumers of @lando/phpmyadmin.
Author
|
Cursor Agent can help with this pull request. Just |
Author
|
Automatically closed this PR because it was created by Bugbot autofix for #74, and that PR was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
Fix: Move test dependencies to devDependencies
This PR addresses a bug where
@lando/mariadband@lando/mysqlwere incorrectly listed underdependenciesinpackage.json. These packages are exclusively used for testing and examples, not as production dependencies for@lando/phpmyadmin. Moving them todevDependenciesprevents unnecessary transitive installations for consumers of this package, reducing its footprint.