Skip to content

chore: deprecate Nix-based build, remove interactive components#4895

Merged
Kha merged 6 commits intoleanprover:masterfrom
Kha:deprecate-nix
Aug 2, 2024
Merged

chore: deprecate Nix-based build, remove interactive components#4895
Kha merged 6 commits intoleanprover:masterfrom
Kha:deprecate-nix

Conversation

@Kha
Copy link
Member

@Kha Kha commented Aug 1, 2024

Users who prefer the flake build should maintain it externally

@Kha Kha enabled auto-merge August 1, 2024 12:03
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 1, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 1, 2024
@ghost ghost added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 1, 2024
@ghost
Copy link

ghost commented Aug 1, 2024

Mathlib CI status (docs):

@Kha Kha requested a review from kim-em as a code owner August 1, 2024 16:00
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 1, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Aug 2, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 2, 2024
@Kha Kha added this pull request to the merge queue Aug 2, 2024
Merged via the queue into leanprover:master with commit efc99b9 Aug 2, 2024
@Kha Kha deleted the deprecate-nix branch August 2, 2024 11:30
@lenianiva
Copy link
Contributor

Are all Nix components going to be removed eventually? I can take over and create a repository for the Nix build paths

@nomeata
Copy link
Collaborator

nomeata commented Oct 7, 2024

I expect that in the long run we certainly keep a nix shell with the build dependencies alive.

We maybe keep using Nix for our own CI uses, but certainly nothing that we’d want other people to import/depend upon.

So if you are motivated to maintain nix-related things in a separate repository, that would be great!

@lenianiva
Copy link
Contributor

I expect that in the long run we certainly keep a nix shell with the build dependencies alive.

We maybe keep using Nix for our own CI uses, but certainly nothing that we’d want other people to import/depend upon.

So if you are motivated to maintain nix-related things in a separate repository, that would be great!

does it mean the downstream nix repo should not depend on any nix file in this repo? I was hoping to reuse as much internal machinery as possible including the (most importantly) buildLeanPackage

@nomeata
Copy link
Collaborator

nomeata commented Oct 7, 2024

It's up to you if course. But it may be easier to copy all that machinery and start taking ownership in the new repository, and adjust it to your needs.

@lenianiva
Copy link
Contributor

I got one working. I'll try to support every major Lean version: https://github.com/lenianiva/lean4-nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants