Check if a batch is expected for commitment_signed#3852
Merged
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom Jun 16, 2025
Merged
Check if a batch is expected for commitment_signed#3852TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
commitment_signed#3852TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
Contributor
Author
wpaulino
reviewed
Jun 12, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
When receiving a commitment_signed message, if there are any pending splices then we are expected to receive the message as a part of a batch. Otherwise, the spec dictates that we should send an error and fail the channel.
jkczyz
force-pushed
the
2025-06-start-batch-fix
branch
from
93e32d0 to
d016801
Compare
Contributor
Author
|
Rebased and added a commit removing |
wpaulino
approved these changes
Jun 13, 2025
TheBlueMatt
approved these changes
Jun 16, 2025
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Fix is fine, but probably we should unify the codepath here - there's no reason we have a separate codepath for single-CS from multi-CS when the multi-CS codepath would work with a single CS just fine.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receiving a
commitment_signedmessage, if there are any pending splices then we are expected to receive the message as a part of a batch. Otherwise, the spec dictates that we should send anerrorand fail the channel.