Demacro process forward htlcs#3956
Conversation
|
👋 I see @tnull was un-assigned. |
joostjager
force-pushed
the
demacro-process-forward-htlcs
branch
from
67fec90 to
e22f49d
Compare
Wasn't previously formatted because it was a macro.
joostjager
force-pushed
the
demacro-process-forward-htlcs
branch
from
e22f49d to
8ccab2b
Compare
lightning/src/ln/channelmanager.rs
Outdated
| &self, short_chan_id: u64, pending_forwards: &mut Vec<HTLCForwardInfo>, | ||
| failed_forwards: &mut Vec<FailedHTLCForward>, | ||
| /// Fail the list of provided HTLC forwards because the channel they were to be forwarded over does no longer exist. | ||
| #[rustfmt::skip] |
There was a problem hiding this comment.
Added skip to make it easy to verify that the code didn't change. View in github without whitespace changes
joostjager
requested review from
TheBlueMatt and
tnull
and removed request for
tankyleo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
==========================================
- Coverage 88.91% 88.88% -0.03%
==========================================
Files 173 173
Lines 123393 123568 +175
Branches 123393 123568 +175
==========================================
+ Hits 109717 109837 +120
- Misses 11216 11280 +64
+ Partials 2460 2451 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Definitely doesn't need a second reviewer, good to land once CI passes.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Ran CI locally. |
3 participants
Macros are bad and unformatted.