Make connect_with_unknown_server actually connect to unknown server#4034
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Sep 1, 2025
Merged
Conversation
This test would fail for me locally because apparently I had apache running. This changes it so we look for an open port instead of just assuming that port 80 is unused.
|
I've assigned @tnull as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4034 +/- ##
==========================================
- Coverage 88.74% 88.73% -0.01%
==========================================
Files 176 176
Lines 128845 128848 +3
Branches 128845 128848 +3
==========================================
- Hits 114340 114337 -3
- Misses 11912 11915 +3
- Partials 2593 2596 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test would fail for me locally because apparently I had apache running. This changes it so we look for an open port instead of just assuming that port 80 is unused.