Correct and clarify comments in ChannelMonitor loading test utils#4055
Conversation
|
👋 I see @valentinewallace was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4055 +/- ##
==========================================
- Coverage 88.75% 88.75% -0.01%
==========================================
Files 176 176
Lines 129410 129410
Branches 129410 129410
==========================================
- Hits 114864 114859 -5
- Misses 11938 11947 +9
+ Partials 2608 2604 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| // At every point where we get a monitor update, we should be able to send a useful monitor | ||
| // to a watchtower and disk... | ||
| // to a watchtower and disk. At a minimum, this means we should be able to round-trip the | ||
| // monitor to a serialized copy and get he same one back. |
There was a problem hiding this comment.
There's a small typo in this comment: "get he same one back" should be "get the same one back".
| // monitor to a serialized copy and get he same one back. | |
| // monitor to a serialized copy and get the same one back. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
TheBlueMatt
requested review from
joostjager
and removed request for
valentinewallace
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
Helpful, especially for newer readers of the code.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
4 participants
From #3996 (review)