Make background-processor NO_* constants actually Send + Sync#4132
Make background-processor NO_* constants actually Send + Sync#4132tnull merged 1 commit intolightningdevkit:mainfrom
NO_* constants actually Send + Sync#4132Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 88.63% 88.60% -0.03%
==========================================
Files 180 180
Lines 134878 134904 +26
Branches 134878 134904 +26
==========================================
- Hits 119543 119535 -8
- Misses 12567 12601 +34
Partials 2768 2768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Should we also add some test coverage for this case then?
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
TheBlueMatt
force-pushed
the
2025-09-async-bp-consts
branch
5 times, most recently
from
68ca292 to
d666e4c
Compare
In 0d59d73 we added constants to better enable users to call background processor methods without optional parameters. Sadly, they didn't work for the async BP as they weren't actually `Send` + `Sync`, which we fix here.
TheBlueMatt
force-pushed
the
2025-09-async-bp-consts
branch
from
d666e4c to
e040fcd
Compare
|
Fixed the no-std build and added test coverage. |
3 participants
In 0d59d73 we added constants to better enable users to call background processor methods without optional parameters. Sadly, they didn't work for the async BP as they weren't actually
Send+Sync, which we fix here.