Correct EOF handling in stream read in ChaChaDualPolyReadAdapter#4144
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Oct 7, 2025
Merged
Correct EOF handling in stream read in ChaChaDualPolyReadAdapter#4144tnull merged 1 commit intolightningdevkit:mainfrom
ChaChaDualPolyReadAdapter#4144tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
When `ChaChaDualPolyReadAdapter` encounters an EOF (`Read::read` returns `Ok(0)`) while trying to drain the stream (even though the `FixedLengthReader` thinks it has available space) we'll end up infinite-looping trying to drain the stream looking for `Read::read` to return an `Err` (which it won't). The fix is, of course, simple, to detect the EOF signal. Found by the `onion_message_target` fuzzer which @dergoegge ran. Thanks to @morehouse for digging deeper on the specific fuzz test case and thoroughly reporting the underlying causes. Fixes lightningdevkit#4139.
|
I've assigned @valentinewallace as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4144 +/- ##
=======================================
Coverage 88.63% 88.64%
=======================================
Files 180 180
Lines 135230 135241 +11
Branches 135230 135241 +11
=======================================
+ Hits 119865 119885 +20
+ Misses 12594 12590 -4
+ Partials 2771 2766 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
morehouse
approved these changes
Oct 6, 2025
Contributor
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
LGTM and verified the fuzz target no longer times out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ChaChaDualPolyReadAdapterencounters an EOF (Read::readreturnsOk(0)) while trying to drain the stream (even though theFixedLengthReaderthinks it has available space) we'll end up infinite-looping trying to drain the stream looking forRead::readto return anErr(which it won't).The fix is, of course, simple, to detect the EOF signal.
Found by the
onion_message_targetfuzzer which @dergoegge ran. Thanks to @morehouse for digging deeper on the specific fuzz test case and thoroughly reporting the underlying causes.Fixes #4139.