Add fmt::Debug implementation for FundedChannel#4183
Add fmt::Debug implementation for FundedChannel#4183jkczyz merged 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
To aid with debugging in tests.
joostjager
requested review from
valentinewallace
and removed request for
jkczyz
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4183 +/- ##
=======================================
Coverage 88.83% 88.84%
=======================================
Files 180 180
Lines 137504 137510 +6
Branches 137504 137510 +6
=======================================
+ Hits 122155 122165 +10
+ Misses 12538 12535 -3
+ Partials 2811 2810 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Outbound, | ||
| } | ||
|
|
||
| #[derive(Debug)] |
There was a problem hiding this comment.
Why are some of these not conditional derived?
There was a problem hiding this comment.
I followed the path of non-conditional derivation for non-public types, and only adding conditionals for public types or when required transitively. @TheBlueMatt mentioned offline "For internal types we should probably mostly just upstream Debug on most structs…"
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. CI has some failures but look unrelated.
3 participants
To aid with debugging in tests.