refactor+graph/db: refactor preparations required for incoming SQL migration code#10011
Merged
guggero merged 6 commits intolightningnetwork:masterfrom Jul 1, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
|
NOTE: the itest flakes both unrelated and fixed in currently open PRs:
|
guggero
approved these changes
Jul 1, 2025
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Just a nit, otherwise LGTM 🎉
So that we can use it in a context that only has access to a kvdb.Backend. We'll use this in our kvdb->SQL migration.
Create a forEachChannel function that does not rely on a KVStore being instantiated. We will use this in our upcoming kvdb->SQL migration.
Small refactor to introduce a re-usable getSourceNode function that we can then make use of in the upcoming kvdb->SQL migration logic.
Refactor channelIDToBytes to return a slice instead of an 8 byte array so that we dont need to use `[:]` everywhere. Also make sure we are using this helper everywhere.
In preparation for the kvdb->migration code, this commit updates `insertChannel` to return the ID of the newly inserted channel along with the IDs of the nodes that the channel links to.
ellemouton
commented
Jul 1, 2025
Collaborator
Author
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
thanks again for the speedy review yall! 🫡
Collaborator
Author
|
cc @guggero for override 🙏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactor. It mainly just does some prep to make a couple of the kv store code re-useable so that we can call the code from the incoming SQL migration without needing to instantiate the entire
KVStorestruct.