sqldb+graph/db: prefix graph SQL objects with "graph_"#10080
sqldb+graph/db: prefix graph SQL objects with "graph_"#10080Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ellemouton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant refactoring of the database schema and its Go language representation by consistently prefixing all graph-related SQL objects with "graph_". This change aims to enhance clarity and prevent naming conflicts with other database domains, such as invoice or payments tables, thereby improving the overall organization and maintainability of the database structure.
Highlights
- Database Schema Renaming: All SQL database tables and their associated indexes related to the graph (e.g., nodes, channels, policies, zombie channels, prune logs, etc.) have been systematically prefixed with
graph_(e.g.,nodesis nowgraph_nodes,channelsis nowgraph_channels). - Go Type Renaming (sqlc): Corresponding
sqlcgenerated Go types have been renamed to reflect thegraph_prefix (e.g.,sqlc.Nodeis nowsqlc.GraphNode,sqlc.Channelis nowsqlc.GraphChannel,sqlc.ChannelPolicyis nowsqlc.GraphChannelPolicy, etc.). - Codebase Adaptation: The Go codebase interacting with these
sqlctypes has been updated to use the newgraph_prefixed type names, ensuring consistency across the application's database layer. - Non-Breaking Change: The author explicitly states this is not a breaking change as the affected tables are currently only used in test builds.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ellemouton
force-pushed
the
graphPrefixTables
branch
from
c9ddca7 to
0091443
Compare
There was a problem hiding this comment.
Code Review
The pull request prefixes graph SQL objects with "graph_". The changes involve modifications to SQL migration files, SQL store files, SQL queries, and data models to reflect the new naming convention. The changes appear to be well-organized and consistently applied.
This makes it more clear what each table is for especially when viewed with other invoice/payments tables.
ellemouton
force-pushed
the
graphPrefixTables
branch
from
0091443 to
74b70a5
Compare
4 participants
This makes it more clear what each table is for especially when viewed with other invoice/payments tables.
This is not a breaking change since none of these tables are available in a non-test build yet.