graph/db: fix potential policy swop#10114
Conversation
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ellemouton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug that could result in a nil pointer dereference within the graph database's caching mechanism. The fix involves ensuring that the correct policy variables are referenced when constructing cached edge policies and setting related flags, thereby improving the stability and correctness of the graph data handling.
Highlights
- Bug Fix: Nil Pointer Dereference: Corrected an issue in
ForEachNodeCachedwhere an incorrect policy variable (p2) was being used to constructCachedEdgePolicy, which could lead to a nil pointer dereference ifinPolicywas the intended variable andp2was not properly initialized or wasnil. - Policy Flag Correction: Updated the
OutPolicySetflag within theChannelEdgestruct to correctly reflect the presence ofoutPolicyby checkingoutPolicy != nilinstead ofp1 != nil, ensuring accurate policy state representation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses a potential nil pointer dereference in ForEachNodeCached by correcting the logic for determining incoming and outgoing channel policies. The changes ensure that the correct policy variables (inPolicy and outPolicy) are used after the policy-swapping logic, which resolves the reported panic. The fixes are correct and improve the robustness of the graph database operations.
While reviewing, I identified a similar potential nil pointer dereference on line 1200, which is outside the scope of the current changes. The outPolicy variable is dereferenced without a nil check, which could lead to a panic if no outgoing policy exists. I recommend addressing this in a follow-up change by adding a nil check before accessing outPolicy.InboundFee.
Here, we fix two bugs that could lead to a nil pointer dereference. Both are caused by refering to policies that may be nil at the call-site.
ellemouton
force-pushed
the
fixPolicySwop
branch
from
f48f55c to
858c064
Compare
3 participants
Here, we fix a bug that could lead to a nil pointer dereference.
NOTE: this code isn't "live" yet, so should not affect any production release.