brontide: fix peer disconnection issue#9872
Merged
Roasbeef merged 3 commits intolightningnetwork:masterfrom Jun 2, 2025
Merged
brontide: fix peer disconnection issue#9872Roasbeef merged 3 commits intolightningnetwork:masterfrom
Roasbeef merged 3 commits intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Roasbeef
reviewed
May 27, 2025
yyforyongyu
reviewed
May 28, 2025
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
Thanks for the fix! It looks like it's a cure for #9622.
Pending linter fixes otherwise good to go!
ziggie1984
force-pushed
the
fix-peer-connection
branch
from
cbf70f2 to
1b7b4aa
Compare
Collaborator
Author
|
Added a simple itest as well which would fail without this new change. |
ziggie1984
force-pushed
the
fix-peer-connection
branch
from
1b7b4aa to
c308a73
Compare
yyforyongyu
reviewed
May 29, 2025
|
|
||
| // testRBFCoopCloseDisconnect tests that when a node disconnects that the node | ||
| // is properly disconnected. | ||
| func testRBFCoopCloseDisconnect(ht *lntest.HarnessTest) { |
Member
There was a problem hiding this comment.
could you add this test in a separate commit so we could run this test to see it fail?
ziggie1984
force-pushed
the
fix-peer-connection
branch
from
c308a73 to
b51a790
Compare
Add a connect/disconnect test when the peers both started up with the rbf coop close feature.
In case when the rbf coop close feature was active we would not properly disconnect the peer.
ziggie1984
force-pushed
the
fix-peer-connection
branch
from
b51a790 to
329c571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case when the rbf coop close feature was active we would not
properly disconnect the peer.