accessman: remove restrictions on protected/temporary peers#9876
Merged
guggero merged 4 commits intolightningnetwork:masterfrom Jun 4, 2025
Merged
accessman: remove restrictions on protected/temporary peers#9876guggero merged 4 commits intolightningnetwork:masterfrom
guggero merged 4 commits intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ziggie1984
approved these changes
May 28, 2025
Collaborator
ziggie1984
left a comment
ziggie1984
left a comment
There was a problem hiding this comment.
Missing release-notes, otherwise LGTM
yyforyongyu
force-pushed
the
fix-accessman
branch
2 times, most recently
from
9776c41 to
fb5563b
Compare
2 tasks
Roasbeef
requested changes
Jun 3, 2025
| ErrNoMoreRestrictedAccessSlots, | ||
| "num_restricted", a.numRestricted, | ||
| "max_restricted", a.cfg.maxRestrictedSlots) | ||
| if a.numRestricted >= a.cfg.maxRestrictedSlots { |
Member
There was a problem hiding this comment.
Looking at some of the call path here, I think this a race: we're not holding banScoreMtx here. So we should either:
- hold it directly
- add helper method that holds and returns the value
- atomic
Member
There was a problem hiding this comment.
Ah ok, it was only introduced in this PR, as the defer above was removed.
Member
Author
There was a problem hiding this comment.
nice catch! now fixed
yyforyongyu
force-pushed
the
fix-accessman
branch
2 times, most recently
from
615120d to
d45621c
Compare
If a peer has, or used to have a channel with us there's no need to check for the ban score.
yyforyongyu
force-pushed
the
fix-accessman
branch
from
d45621c to
e0b6acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a peer has, or used to have a channel with us there's no need to check for the ban score.