[14] graph/db: implement more SQLStore methods by ellemouton · Pull Request #9938 · lightningnetwork/lnd

ellemouton · 2025-06-12T09:32:49Z

Here, we implement:

FetchChannelEdgesByOutpoint/SCID
HasChannelEdge
ChannelID
FilterKnownChanIDs
FetchChanInfos
IsPublicNode
DisabledChannelIDs

Part of #9795
See #9932 for the full picture that we are aiming at

coderabbitai · 2025-06-12T09:32:56Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

lightninglabs-deploy · 2025-06-19T12:18:05Z

@bhandras: review reminder

guggero

Great work, these PRs are really easy to get through 💯

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

guggero

Very nice work, LGTM 🎉

bhandras

LGTM ✨

bhandras · 2025-06-24T17:00:53Z

graph/db/sql_store.go

+			ctx, db, dbPol1, dbPol2, edge.ChannelID, node1, node2,
+		)
+		if err != nil {
+			return fmt.Errorf("unable to build channel "+


nit: should we standardize these errors so we wouldn't need to duplicate the strings (and makes it easier to match against them if needed). (ofc if you agree can come in a later PR).

cool yes, can do - will do in follow up 👍
by standardise, do you mean just letting the function itself return the string in question and then just doing return err here?

I just meant that it could be useful to create predefined errors for those that we reuse across functions.

cool - made a note here to track: #9795

And run `TestEdgeInsertionDeletion` against our SQL backends.

And run `TestEdgeInfoUpdates` against our SQL backends.

Which lets us then run `TestFilterKnownChanIDsZombieRevival` and `TestFilterKnownChanIDs` against our SQL backends.

Which lets us run `TestFilterChannelRange` against our SQL backends.

Which lets us run `TestNodeIsPublic` against our SQL DB backends. Note that we need to tweak the tests a little bit so that `AddLightningNode` for the same node is always called with a newer LastUpdate time else it will fail the SQL constraint that only allows the upsert if the update is newer than the persisted one.

Which lets us run `TestDisabledChannelIDs` against our SQL DB backends.

ellemouton · 2025-06-25T07:05:08Z

cc @guggero for override merge 🙏 - check-commits is getting stuck for some reason - but it does pass locally.
let me know if you prefer if I re-push instead

ellemouton added this to the v0.20.0 milestone Jun 12, 2025

ellemouton self-assigned this Jun 12, 2025

ellemouton added graph sql labels Jun 12, 2025

ellemouton mentioned this pull request Jun 12, 2025

[15] graph/db: SQL prune log #9939

Merged

ellemouton requested a review from bhandras June 12, 2025 12:11

ellemouton removed the request for review from bhandras June 19, 2025 12:51

ellemouton force-pushed the elle-graph14 branch from 56d3be6 to afe7676 Compare June 20, 2025 13:57

ellemouton force-pushed the graphSQL14 branch 4 times, most recently from 966e56d to f909068 Compare June 20, 2025 14:13

ellemouton requested review from bhandras and guggero June 20, 2025 16:32

guggero reviewed Jun 23, 2025

View reviewed changes

ellemouton force-pushed the elle-graph14 branch from afe7676 to 64bc4e7 Compare June 24, 2025 11:32

ellemouton force-pushed the graphSQL14 branch from f909068 to 4578b8a Compare June 24, 2025 11:32

ellemouton commented Jun 24, 2025

View reviewed changes

ellemouton requested a review from guggero June 24, 2025 12:10

guggero approved these changes Jun 24, 2025

View reviewed changes

bhandras approved these changes Jun 24, 2025

View reviewed changes

ellemouton added 6 commits June 24, 2025 21:04

graph/db+sqldb: implement FetchChannelEdgesByOutpoint/SCID

4fad4a7

And run `TestEdgeInsertionDeletion` against our SQL backends.

graph/db+sqldb: implement HasChannelEdge and ChannelID

13bf6a5

And run `TestEdgeInfoUpdates` against our SQL backends.

graph/db: impl FilterKnownChanIDs

ba701de

Which lets us then run `TestFilterKnownChanIDsZombieRevival` and `TestFilterKnownChanIDs` against our SQL backends.

graph/db: implement FetchChanInfos

acae165

Which lets us run `TestFilterChannelRange` against our SQL backends.

graph/db+sqldb: impl DisabledChannelIDs

eec8936

Which lets us run `TestDisabledChannelIDs` against our SQL DB backends.

ellemouton changed the base branch from elle-graph14 to master June 24, 2025 19:06

ellemouton force-pushed the graphSQL14 branch from 4578b8a to eec8936 Compare June 24, 2025 19:06

guggero merged commit 33e6f28 into lightningnetwork:master Jun 25, 2025
60 of 70 checks passed

ellemouton deleted the graphSQL14 branch June 25, 2025 08:44

ellemouton mentioned this pull request Jun 25, 2025

[epic]: graph db: SQL implementation & migration #9795

Closed

84 tasks

Conversation

ellemouton commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

lightninglabs-deploy commented Jun 19, 2025

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

bhandras Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

bhandras Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ellemouton commented Jun 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)