lntest: enable neutrino testing with bitcoind#9977
Merged
yyforyongyu merged 4 commits intolightningnetwork:masterfrom Jun 23, 2025
Merged
lntest: enable neutrino testing with bitcoind#9977yyforyongyu merged 4 commits intolightningnetwork:masterfrom
yyforyongyu merged 4 commits intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
starius
changed the title
Enable this in bitcoind mode as well to be able to let a subset of LND nodes to use neutrino with bitcoind backend.
Use an additional -bind flag instead of -port to specify the default p2p port. Flag -port sets the default port number that will be used for any -bind or -whitebind that does not explicitly specify a port. So if we have the p2p port set in -port and the tor p2p port set in a single -bind, bitcoind binds only one port - the tor p2p port. And the default p2p port remained not bound!
It is useful if we want to keep bitcoind main itest mode, but connect one node using neutrino.
starius
force-pushed
the
itest-bitcoind-neutrino
branch
from
a12381d to
7b70ad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Previously, Neutrino could be enabled via the
neutrinobuild tag, which affected all LND nodes involved in an itest and required using abtcdminer as the source of compact block headers. This PR introduces a more flexible setup: it is now possible to run some LND nodes with a regularbitcoindbackend, while others use Neutrino withbitcoind's P2P interface as the source of compact block headers. This allows testing more complex scenarios where some nodes have a localbitcoindinstance, while others rely on Neutrino for lightweight syncing.Steps to Test
The change is fully backwards compatible, and all existing itests should continue to pass.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.