AuxTrafficShaper methods use first hop pub key#9980
AuxTrafficShaper methods use first hop pub key#9980guggero merged 3 commits intolightningnetwork:masterfrom
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ziggie1984
left a comment
There was a problem hiding this comment.
Guess the itest is in the linked taproot PR. Left some minor comments.
guggero
left a comment
There was a problem hiding this comment.
We could avoid using a pointer, see inline comment. But because we create a copy of the pubkey/vertex anyway, I don't have strong feelings about it.
So LGTM 🎉
500e466 to
8f33b2c
Compare
8f33b2c to
4ad8462
Compare
|
Let's also add release notes tho |
Description
We enhance the aux traffic shaper methods
ProduceHtlcExtraData&PaymentBandwidthto now also include the pub key of the peer this HTLC is going to be sent to.