fix: breaking cycle issues and replacing router.push with Links#3330
Merged
sriramveeraghanta merged 4 commits intodevelopfrom Jan 8, 2024
Merged
fix: breaking cycle issues and replacing router.push with Links#3330sriramveeraghanta merged 4 commits intodevelopfrom
sriramveeraghanta merged 4 commits intodevelopfrom
Conversation
| General | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Members | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/members`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Billing and Plans | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/billing`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Integrations | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/integrations`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Import | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/imports`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| <div className="flex items-center gap-1.5"> | ||
| <CustomMenu.MenuItem key={moduleDetail.id}> | ||
| <Link | ||
| href={`/${workspaceSlug}/projects/${projectId}/modules/${moduleDetail.id}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| <div className="flex items-center gap-1.5"> | ||
| <CustomMenu.MenuItem key={viewId}> | ||
| <Link | ||
| href={`/${workspaceSlug}/projects/${projectId}/views/${viewId}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
Comment on lines
+54
to
+56
| href={`/${workspaceSlug}/projects/${notification.project}/${ | ||
| notification.data.issue_activity.field === "archived_at" ? "archived-issues" : "issues" | ||
| }/${notification.data.issue.id}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
|
|
||
| router.push(`/${workspaceSlug}/projects/${project.id}/settings`); | ||
| }} | ||
| href={`/${workspaceSlug}/projects/${project.id}/settings`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Go to issues | ||
| </Button> | ||
| //TODO: Create a new component called Button Link to handle such scenarios | ||
| <Link href={`/${workspaceSlug}/projects/${projectId}/issues`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
sriramveeraghanta
approved these changes
Jan 8, 2024
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <[email protected]>
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <[email protected]>
vamsikrishnamathala
pushed a commit
that referenced
this pull request
Aug 7, 2025
* chore: added code split for the analytics store * chore: done some refactor * refactor: update entity keys in analytics and translations * chore: updated the translations * refactor: simplify AnalyticsStoreV2 class by removing unnecessary constructor * feat: add AnalyticsStoreV2 class and interface for enhanced analytics functionality * feat: enhance WorkItemsModal and analytics store with isEpic functionality * feat: integrate isEpic state into TotalInsights and WorkItemsModal components * refactor: remove isEpic state from WorkItemsModalMainContent component * refactor: removed old analytics components and related services * refactor: new analytics * refactor: removed all nivo chart dependencies * chore: resolved coderabbit comments * fix: remove duplicate isEpic prop in WorkItemsModal component * fix: update type for tab parameter in processUrl method of AnalyticsV2Service * fix: update processUrl to handle custom-work-items in peek view * feat: implement CSV export functionality in InsightTable component * feat: add user analytics components and extend analytics functionality * feat: enhance analytics service with filter parameters and improve data handling in InsightTable * feat: add projects analytics components * feat: add cycles, modules, and intake analytics components with corresponding data handling and visualization * feat: add new translation keys for various statuses across multiple languages * chore: update analytics components and translations * [WEB-4246] fix: enhance analytics components to include 'isEpic' parameter for improved data fetching * refactor: clean up imports and update translation keys in analytics components * chore: added project logo props in charts * feat: integrate project logo display in analytics tables * chore: added feature flag * chore: disabled users * chore: added feature flag * chore: added payment failure vaidation * feat: enhance analytics page with subscription upgrade tooltip and update translations * updated translations * chore: added additional parameters in payload * added state icons in module and cycle table * fix: handle empty date values in cycles and modules insight tables * chore: added the keys for module * chore: added custom tooltip for cycles and modules * chore: added color to the scatter points * refactor: centralize module status colors and update chart point colors and yaxis domain * fix: update comment to clarify display name usage in WorkItemInsightColumns * feat: add completed work items count to analytics and update chart components * refactor: update trend-piece component to use new status variants for analytics * feat: enhance ee analytics tables with export functionality and added project logo in intake * refactor: clean up fetch keys and simplify analytics component structure * refactor: rename analytics fields constants for consistency and clarity * refactor: update analytics feature flag for improved clarity and consistency * chore: changed the feature flag of analytics * refactor: streamline analytics tab structure and introduce locked tab labels for feature flag check while rendering tab label * chore: remove unused translation key for entity count in English locale * fix: import of intake * fix: append percentage sign to completion percentage label in cycles insight table * refactor: simplify completion percentage calculation in ModulesCyclesTooltip and enhance Avatar component styling in UserAvatarName * refactor: update AnalyticsWrapper titles to use i18n keys and clean up imports in analytics components * fix: update isEpic handling in WorkItemsModal to consider isPeekView state * fix: update i18n title in AnalyticsWrapper for Intake component --------- Co-authored-by: NarayanBavisetti <[email protected]> Co-authored-by: Aaryan Khandelwal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in creating a new cycle, restructure the active cycles inside cycles store and review and replace router.pushes