#2101 inherited properties need to be analysed against redefined properties when inheriting mappings#2103
Merged
sjaakd merged 5 commits intomapstruct:masterfrom Jul 4, 2020
Merged
Conversation
Contributor
Author
|
@filiphr .. shall we add the reproducer anyway..? Always good to have additional UT. |
Member
|
This is a tricky one. Basically what happens it the following mapper: Perhaps when doing the inverse inheritance if there is a target mapping which has the reversed segment we should not use it. |
filiphr
approved these changes
Jul 4, 2020
Member
filiphr
left a comment
There was a problem hiding this comment.
LGTM. I have only one comment
processor/src/main/java/org/mapstruct/ap/internal/model/source/MappingMethodOptions.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly need to add some unit test.. Although quite some testcases failed when I implemented it wrong 😄