#2840, #2913, #2921: MethodMatcher should not match widening methods#3032
Merged
filiphr merged 3 commits intomapstruct:mainfrom Sep 27, 2022
Merged
#2840, #2913, #2921: MethodMatcher should not match widening methods#3032filiphr merged 3 commits intomapstruct:mainfrom
filiphr merged 3 commits intomapstruct:mainfrom
Conversation
…not match widening methods In the MethodMatcher we need to do a special check when the target type is primitive. The reason for that is that a Long is assignable to a primitive double. However, doing that means that information can be lost and thus we should not pick such methods. When the target type is primitive, then a method will be matched if and only if boxed equivalent of the target type is assignable to the boxed equivalent of the candidate return type
This was referenced Sep 26, 2022
Zegveld
approved these changes
Sep 26, 2022
Contributor
Zegveld
left a comment
Zegveld
left a comment
There was a problem hiding this comment.
Looks good to me, did find a single typo. ;)
processor/src/main/java/org/mapstruct/ap/internal/model/source/MethodMatcher.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the MethodMatcher we need to do a special check when the target type is primitive. The reason for that is that a Long is assignable to a primitive double. However, doing that means that information can be lost and thus we should not pick such methods. When the target type is primitive, then a method will be matched if and only if boxed equivalent of the target type is assignable to the boxed equivalent of the candidate return type.
Fixes #2840
Fixes #2913
Fixes #2921