fix: respect NullValuePropertyMappingStrategy.IGNORE for collections without setters#3866
Merged
filiphr merged 3 commits intomapstruct:mainfrom May 31, 2025
Merged
fix: respect NullValuePropertyMappingStrategy.IGNORE for collections without setters#3866filiphr merged 3 commits intomapstruct:mainfrom
filiphr merged 3 commits intomapstruct:mainfrom
Conversation
…without setters Signed-off-by: TangYang <[email protected]>
filiphr
reviewed
May 25, 2025
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Looks good. I had some questions through while reviewing this.
processor/src/test/java/org/mapstruct/ap/test/bugs/_3806/DestinationType.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/bugs/_3806/Issue3806Test.java
Outdated
Show resolved
Hide resolved
Signed-off-by: TangYang <[email protected]>
Contributor
Author
|
@filiphr Improved some tests. plz review again. |
filiphr
approved these changes
May 31, 2025
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks @tangyang9464. I did a small polish and I also adjusted the test case a bit, since it wasn't failing if I removed your changes.
filiphr
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3806