Support of Historical dates (years only)#3
Merged
kochrt merged 1 commit intomark-when:mainfrom Oct 12, 2024
Deuh:bce-dates
Merged
Support of Historical dates (years only)#3kochrt merged 1 commit intomark-when:mainfrom Deuh:bce-dates
kochrt merged 1 commit intomark-when:mainfrom
Deuh:bce-dates
Conversation
kochrt
approved these changes
Oct 12, 2024
Member
kochrt
left a comment
There was a problem hiding this comment.
LGTM, it's missing a couple things of course, like months and days like you pointed out, as well as event ids and relative dates/durations. But! that can be for another time.
Thank you for doing this!
|
|
||
|
|
||
| /** | ||
| * NOTE: I find it weird that the expectedTo date is always the next day at 00:00:00. Shouldn't it be the same day at 23:59:59? |
Member
There was a problem hiding this comment.
It's an open range from the start up to but not including the end [from, to)
|
Hello dear hard workers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for historical date
This branch is to implement support for BCE/BC and CE/AD dates.
This implementation cover only the Year and will not works with month, day etc.
Note:
Implementation was done only with the added test to verify it's working. Maybe some additional testing would be needed
Changes
Known issues:
AD 70). For simplicity and to align with other notation AD should be after the year: "5 AD: Some event"Example:
Refer to
tests/dates.test.tsto see some examplesTests result:
Failing test are already failing on main branch:
This branch