[Catalog] workaround for #3635 ([Navigation Drawer] Unify scrim color)#4530
Open
manabu-nakamura wants to merge 2 commits intomaterial-components:masterfrom
Open
[Catalog] workaround for #3635 ([Navigation Drawer] Unify scrim color)#4530manabu-nakamura wants to merge 2 commits intomaterial-components:masterfrom
manabu-nakamura wants to merge 2 commits intomaterial-components:masterfrom
Conversation
…] Unify scrim color)
drchen
reviewed
Jan 6, 2025
| unregisterBackCallback(); | ||
| } | ||
| }); | ||
| drawerLayout.setScrimColor(0x52000000); |
Contributor
There was a problem hiding this comment.
Define it as a color resource?
Contributor
Author
There was a problem hiding this comment.
I tried using mtrl_scrim_color:
drawerLayout.setScrimColor(ContextCompat.getColor(this, R.color.mtrl_scrim_color));<!-- 32% opacity black -->
<color name="mtrl_scrim_color">#52000000</color>…] Unify scrim color)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3635
#4295
https://issuetracker.google.com/issues/365245820