Correctly go through property setter when init'ing Timer interval.#17160
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Apr 17, 2020
Merged
Correctly go through property setter when init'ing Timer interval.#17160QuLogic merged 1 commit intomatplotlib:masterfrom
QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
anntzer
force-pushed
the
timerintinterval
branch
from
98b19f0 to
4eb6649
Compare
timhoffm
reviewed
Apr 16, 2020
anntzer
force-pushed
the
timerintinterval
branch
from
4eb6649 to
5e3498f
Compare
QuLogic
approved these changes
Apr 16, 2020
timhoffm
approved these changes
Apr 16, 2020
Member
|
This appears to be broken on some backends. |
anntzer
force-pushed
the
timerintinterval
branch
from
5e3498f to
8ffaf34
Compare
Contributor
Author
|
Hopefully fixed, and caught a bug on timerwx at the same time (see changelog). |
The setter casts the interval to an int, which is required at least by the tk backend. This caught a bug in the wx timer, where just setting the interval would start the timer. Fixed that.
anntzer
force-pushed
the
timerintinterval
branch
from
55b7d30 to
96690e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter casts the interval to an int, which is required at least by
the tk backend.
Closes #17149 (comment).
PR Summary
PR Checklist