Merged
Conversation
This version is broken on Windows: zeromq/pyzmq#1470.
QuLogic
changed the title
Cairo backends save the `cairo_t` object on the graphics context (as `self.gc.ctx`), but this object is not threadsafe.
tacaswell
reviewed
Jan 15, 2021
QuLogic
commented
Jan 15, 2021
| backend, | ||
| marks=pytest.mark.xfail(reason='github #16849')) | ||
| marks.append(pytest.mark.xfail(reason='github #16849')) | ||
| backend = pytest.param(backend, marks=marks) |
Member
Author
There was a problem hiding this comment.
This change ensures we always have a pytest.param, so that the later loop is simpler.
7 tasks
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jan 15, 2021
QuLogic
added a commit
that referenced
this pull request
Jan 15, 2021
…3.3.x Backport PR #19301 on branch v3.3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This version is broken on Windows: fix bundling msvcp on Python 3.9 zeromq/pyzmq#1470.
Cairo backends save the
cairo_tobject on the graphics context (asself.gc.ctx), but this object is not threadsafe.This should fix sporadic failures in
test_interactive_thread_safety.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).