Clarify/Improve docs on family-names vs generic-families#20346
Clarify/Improve docs on family-names vs generic-families#20346jklymak merged 2 commits intomatplotlib:masterfrom
Conversation
anntzer
left a comment
anntzer
left a comment
There was a problem hiding this comment.
Looks good to me, but perhaps someone less familiar with fonts should check whether this looks like an improvement to them :)
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
I think I'm ignorant enough about what is going on to say this raises more questions than it answers ;-). Apologies if this is explained elsewhere and I just could not find it.
I also am not at all sure this belongs in a tutorial called text_props. But maybe re-org can happen later? I think the tutorial should have "font" in the title somewhere....
|
^reworded sentences as per @jklymak's suggestions.
Yes, I think that's definitely something which we should consider, though we should discuss where and how exactly font-related docs could be abstracted/put. |
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
This seems better to me, thanks!
These failures look real and related. |
Yeah even I was confused when I first saw it, it's basically coming from matplotlib/tutorials/text/text_props.py Line 184 in 5d7979b Is there any other way we can reference this link: https://matplotlib.org/stable/tutorials/introductory/customizing.html? |
|
Aren't those usually Edit: see contour_demo.py for seeming to work. Sorry I don't know why |
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Anyone can merge when CI passes, though @aitikgupta you may want to squash your commits?
|
I was waiting for tests to pass first, but I can squash and push right now? |
|
I don't think there is any reason for CI to run twice, unless you want to keep the commits around for some reason. |
|
Thanks @aitikgupta - looks helpful! |
5 participants
PR Summary
Coming from the answer at https://discourse.matplotlib.org/t/fonts-and-font-families/22132 and a brief discussion with @anntzer, this PR modifies the content of font docs (and one example, for which I have a slight niggle against - because it's not really the most obvious and best way to guide a user into setting font family).
Hopefully, we might be moving font stuff out from this very long page, and probably a better example in future.
This is possibly the beginning of handling #5941.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).