Emit non BMP chars as XObjects in PDF#20633
Merged
QuLogic merged 2 commits intomatplotlib:masterfrom Jul 22, 2021
Merged
Conversation
sauerburger
force-pushed
the
pdf-non-bmp-chars
branch
from
675a7b2 to
cded989
Compare
aitikgupta
approved these changes
Jul 13, 2021
Test that character beyond the Basic Multilingual Plane are supported in PDF files with Type 42 fonts. The example tests STIX Sans math chars and a char from an old script.
sauerburger
force-pushed
the
pdf-non-bmp-chars
branch
from
cded989 to
08872c7
Compare
QuLogic
reviewed
Jul 20, 2021
Currently, the CID maps only support 2-byte fixed-width characters. Unicode points beyond the Basic Multilingual Plane cannot be used. This comment follows the strategy taken for Type 3 fonts. Any char with a code point > 65535 is emitted as an XObject.
sauerburger
force-pushed
the
pdf-non-bmp-chars
branch
from
08872c7 to
a4067a0
Compare
jklymak
approved these changes
Jul 22, 2021
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
I'm approving in lieu of @aitikgupta, not because I understand the font handling here.
QuLogic
approved these changes
Jul 22, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #20616
This PR address #20616 and emits Type 42 chars from beyond the Basic Multilingual Plane as XObjects, similar to the treatment of multi-byte chars in Type 3 fonts.
This PR builds on top of #20615.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).