Simplify example: Box plots with custom fill colors#27781
Merged
timhoffm merged 2 commits intomatplotlib:mainfrom Feb 13, 2024
Merged
Simplify example: Box plots with custom fill colors#27781timhoffm merged 2 commits intomatplotlib:mainfrom
timhoffm merged 2 commits intomatplotlib:mainfrom
Conversation
The [original example](https://matplotlib.org/3.8 .0/gallery/statistics/boxplot_color.html) was more complex than need be: - The two plots only differed in the `notch=True` parameter, which is irrelevant for custom fill colors -> reduce to one - rework to a more realistic-like plot
rcomer
approved these changes
Feb 13, 2024
Member
rcomer
left a comment
There was a problem hiding this comment.
One small typo but otherwise looks good to me.
| np.random.normal(120, 30, size=100), | ||
| ] | ||
| labels = ['peaches', 'oranges', 'tomatos'] | ||
| colors = ['peachpuff', 'orange', 'tomato'] |
Member
There was a problem hiding this comment.
I did not know these colours existed by using them here is 😎
Member
Author
There was a problem hiding this comment.
Actually, I checked https://matplotlib.org/devdocs/gallery/color/named_colors.html and chose the fruits after available color names 😎
Co-authored-by: Ruth Comer <[email protected]>
Impaler343
pushed a commit
to Impaler343/matplotlib
that referenced
this pull request
Mar 8, 2024
Simplify example: Box plots with custom fill colors The [original example](https://matplotlib.org/3.8 .0/gallery/statistics/boxplot_color.html) was more complex than need be: - The two plots only differed in the `notch=True` parameter, which is irrelevant for custom fill colors -> reduce to one - rework to a more realistic-like plot --------- Co-authored-by: Ruth Comer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original example was more complex than need be:
notch=Trueparameter, which is irrelevant for custom fill colors -> reduce to one