TST: handle change in pytest.importorskip behavior#28925
Merged
tacaswell merged 2 commits intomatplotlib:mainfrom Oct 7, 2024
Merged
TST: handle change in pytest.importorskip behavior#28925tacaswell merged 2 commits intomatplotlib:mainfrom
tacaswell merged 2 commits intomatplotlib:mainfrom
Conversation
It now warns if the module is found, but fails to import (rather than not existing and raising ModuleNotFound).
Apparently, Azure updated from macOS 12 to 14, which caused the change in results outside of the Intel->ARM change.
QuLogic
force-pushed
the
tst/pytest_tkinter
branch
from
2c9022b to
c5e3387
Compare
Member
|
Since #28923 didn't yet work, I've pushed an update to the tolerance here. |
timhoffm
approved these changes
Oct 7, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 7, 2024
QuLogic
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 18, 2024
QuLogic
added a commit
that referenced
this pull request
Oct 18, 2024
…925-on-v3.9.x Backport PR #28925 on branch v3.9.x (TST: handle change in pytest.importorskip behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now warns if the module is found, but fails to import (rather than not existing and raising ModuleNotFound).