removing windows partial new line token from the version#728
Merged
simonl2002 merged 5 commits intomasterfrom May 5, 2023
Merged
removing windows partial new line token from the version#728simonl2002 merged 5 commits intomasterfrom
simonl2002 merged 5 commits intomasterfrom
Conversation
dianadoherty
approved these changes
May 5, 2023
maha-mstfa
reviewed
May 5, 2023
Co-authored-by: Maha Hajja <[email protected]>
This fixes the path dependent issue where the CLI output was not getting trimmed on the code path were an error didn't occur.
jayjayjpg
approved these changes
May 5, 2023
Contributor
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
This reads great, thank you for the super quick fix and triage! ✨
simonl2002
reviewed
May 5, 2023
Comment on lines
285
to
287
| if match == nil || len(match) < 2 { | ||
| return "", fmt.Errorf("output is formatted unexpectedly") | ||
| } |
Contributor
There was a problem hiding this comment.
I didn't make these changes but it feels like given what's being done in version.go GetVersion function, it feels like this should NOT actually be returning an error. Instead we should properly handle both forms of the response output here rather than relying on the caller to clean things up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #727
Type of change