Skip to content

Detect when same version of app has been deployed#753

Merged
raulb merged 5 commits intomasterfrom
lk/refactor-pending-app-updates
May 26, 2023
Merged

Detect when same version of app has been deployed#753
raulb merged 5 commits intomasterfrom
lk/refactor-pending-app-updates

Conversation

@lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented May 25, 2023

Description of change

This PR also refactors some of the error handling and app state detection.

m apps deploy
Validating your app.json...
	✔ Checked your language is "golang"
	✔ Checked your application name is "filter-app"
Checking for uncommitted changes...
	✔ No uncommitted changes!
	✔ App "filter-app" is up-to-date

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

Lyubo Kamenov added 4 commits May 25, 2023 14:01
This PR refactors some of the error handling and app state detection.
Copy link
Contributor

@anna-cross anna-cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyuboxa lyuboxa self-assigned this May 25, 2023
@@ -1,6 +1,34 @@
package apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@raulb raulb merged commit 75a1ed1 into master May 26, 2023
@raulb raulb deleted the lk/refactor-pending-app-updates branch May 26, 2023 08:55
@lyuboxa lyuboxa mentioned this pull request May 27, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants