Revert "Exit 1 when grpc requests fail"#772
Merged
janelletavares merged 1 commit intomasterfrom Jun 9, 2023
Merged
Conversation
This reverts commit f5dd05a.
dianadoherty
approved these changes
Jun 9, 2023
Contributor
dianadoherty
left a comment
dianadoherty
left a comment
There was a problem hiding this comment.
Feel free to revert this, but I think there a lot of value to keeping it un-reverted. This PR helped uncover a really important bug that I think is worth leaving it around for :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #771