Closed
Conversation
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
…soft#121) - Added a new dependency `vecshard` version "0.2.1" in the Cargo.toml file. - Updated `NovaWitness` trait method `r1cs_instance_and_witness` to consume self, impacting its implementation in `SatisfyingAssignment`. - Replaced slicing operations with in-place split for `input_assignment` using `ShardExt` trait. - Removed unnecessary variable references in `R1CSWitness::new` and `R1CSInstance::new` function calls. - Refactored `new` methods in `R1CSWitness` and `R1CSInstance` to accept `Vec` instead of a slice, and removed redundant `.to_owned()` operation.
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
microsoft#121)" (microsoft#125) This reverts commit fdf8296. This should allow us to investigate the effects of components of lurk-lang/arecibo#118 without noise. We can re-apply this later if we see it as an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.