Skip to content

New head#121

Closed
lyronctk wants to merge 4 commits intomicrosoft:mainfrom
lyronctk:new-head
Closed

New head#121
lyronctk wants to merge 4 commits intomicrosoft:mainfrom
lyronctk:new-head

Conversation

@lyronctk
Copy link

No description provided.

@lyronctk lyronctk closed this Jan 14, 2023
huitseeker added a commit to huitseeker/Nova that referenced this pull request Nov 22, 2023
…soft#121)

- Added a new dependency `vecshard` version "0.2.1" in the Cargo.toml file.
- Updated `NovaWitness` trait method `r1cs_instance_and_witness` to consume self, impacting its implementation in `SatisfyingAssignment`.
- Replaced slicing operations with in-place split for `input_assignment` using `ShardExt` trait.
- Removed unnecessary variable references in `R1CSWitness::new` and `R1CSInstance::new` function calls.
- Refactored `new` methods in `R1CSWitness` and `R1CSInstance` to accept `Vec` instead of a slice, and removed redundant `.to_owned()` operation.
huitseeker added a commit to huitseeker/Nova that referenced this pull request Nov 22, 2023
microsoft#121)" (microsoft#125)

This reverts commit fdf8296.

This should allow us to investigate the effects of components of lurk-lang/arecibo#118 without noise.
We can re-apply this later if we see it as an improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant