Rename mlkzg and remove redundant transcript absorbs#299
Merged
srinathsetty merged 2 commits intomainfrom Jan 24, 2024
Merged
Conversation
huitseeker
added a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 25, 2024
This is a port of the following upstream PRs: - microsoft/Nova#299 - microsoft/Nova#300
huitseeker
added a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 25, 2024
This is a port of the following upstream PRs: - microsoft/Nova#299 - microsoft/Nova#300
github-merge-queue bot
pushed a commit
to lurk-lang/arecibo
that referenced
this pull request
Jan 26, 2024
* refactor: move mlkzg -> hyperkzg * refactor: Refactor HyperKZG comments This is a port of the following upstream PRs: - microsoft/Nova#299 - microsoft/Nova#300 * refactor: Refactor engine and testing parameters in pcs.rs - in the IPA Evaluation Engine, transitioning from GrumpkinEngine to Bn256Engine, - avoids noise due to field arithmetic differences
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Feb 14, 2024
…adgets (microsoft#299) - Change the parameter of `AllocatedPoint` from an `Engine` to the more minimal setup of a `Group` - Ensure no changes are made to the operating logic of the code, only type specification has been updated. Downstream changes: - Modify data type of `W` and `E` fields in structures `AllocatedR1CSInstance` and `AllocatedRelaxedR1CSInstance` to `AllocatedPoint<E::GE>` along with the type of `T` parameter in `fold_with_r1cs`. - Update `conditionally_select_point` function in `gadgets/r1cs.rs` to use a generic parameter `G` that inherits from `Group` instead of `E` from `Engine`. - Update method signatures in `NovaAugmentedCircuit` and `SuperNovaAugmentedCircuit` to accommodate changes in the underlying type of `AllocatedPoint` from `E` to `E::GE`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit (for identifying redundant transcript absorbs): adr1anh