feat(49962): Disallow comparison against NaN by a-tarasyuk · Pull Request #50626 · microsoft/TypeScript

a-tarasyuk · 2022-09-03T16:25:32Z

src/compiler/checker.ts

DanielRosenwasser · 2022-09-14T22:58:34Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this faster

typescript-bot · 2022-09-14T22:58:37Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at fb44a1d. You can monitor the build here.

typescript-bot · 2022-09-14T22:58:37Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at fb44a1d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-14T22:58:37Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at fb44a1d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-14T22:58:37Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at fb44a1d. You can monitor the build here.

typescript-bot · 2022-09-14T23:13:51Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50626/merge:

Everything looks good!

typescript-bot · 2022-09-14T23:18:13Z

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

src/compiler/checker.ts

typescript-bot · 2022-09-15T00:20:08Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/50626/merge:

Everything looks good!

DanielRosenwasser · 2022-09-16T19:19:28Z

Weird that the perf test failed?

@typescript-bot perf test this faster

typescript-bot · 2022-09-16T19:19:31Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 5ca49bb. You can monitor the build here.

DanielRosenwasser · 2022-09-16T22:26:06Z

Experimenting with the perf test issues over at #50812

…eat/49962

DanielRosenwasser · 2022-09-20T17:25:12Z

@navya9singh @weswigham can you try to take a quick look? I think this is in a pretty good state, but I'd like to get at least one more pair of eyes by end-of-day before merging.

a-tarasyuk · 2022-09-20T17:26:45Z

@DanielRosenwasser Could you run perf test? I think @typescript-bot was fixed.

weswigham · 2022-09-20T18:03:13Z

@typescript-bot perf test this faster

typescript-bot · 2022-09-20T18:03:15Z

Heya @weswigham, I've started to run the abridged perf test suite on this PR at 89c00e6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-20T18:59:49Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50626

_Metric	_main	₅₀₆₂₆	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,972k (± 0.01%)}	_{338,973k (± 0.00%)}	_{+2k (+ 0.00%)}	_338,950k	_338,999k
_{Parse Time}	_{2.06s (± 0.76%)}	_{2.06s (± 0.64%)}	_{-0.00s (- 0.10%)}	_2.03s	_2.09s
_{Bind Time}	_{0.80s (± 0.75%)}	_{0.80s (± 0.43%)}	_{+0.00s (+ 0.13%)}	_0.79s	_0.80s
_{Check Time}	_{5.87s (± 0.25%)}	_{5.89s (± 0.46%)}	_{+0.02s (+ 0.34%)}	_5.83s	_5.93s
_{Emit Time}	_{6.25s (± 0.34%)}	_{6.26s (± 0.72%)}	_{+0.01s (+ 0.19%)}	_6.18s	_6.39s
_{Total Time}	_{14.98s (± 0.22%)}	_{15.01s (± 0.46%)}	_{+0.04s (+ 0.23%)}	_14.89s	_15.21s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,212k (± 0.01%)}	_{190,798k (± 0.67%)}	_{+587k (+ 0.31%)}	_190,170k	_195,996k
_{Parse Time}	_{0.86s (± 0.40%)}	_{0.85s (± 0.58%)}	_{-0.00s (- 0.35%)}	_0.84s	_0.86s
_{Bind Time}	_{0.48s (± 0.77%)}	_{0.49s (± 0.70%)}	_{+0.00s (+ 0.41%)}	_0.48s	_0.49s
_{Check Time}	_{6.76s (± 0.42%)}	_{6.76s (± 0.82%)}	_{+0.00s (+ 0.04%)}	_6.65s	_6.89s
_{Emit Time}	_{2.43s (± 0.76%)}	_{2.41s (± 0.90%)}	_{-0.01s (- 0.54%)}	_2.38s	_2.48s
_{Total Time}	_{10.53s (± 0.38%)}	_{10.52s (± 0.68%)}	_{-0.01s (- 0.09%)}	_10.37s	_10.65s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,550k (± 0.01%)}	_{326,567k (± 0.00%)}	_{+17k (+ 0.01%)}	_326,539k	_326,608k
_{Parse Time}	_{1.59s (± 0.57%)}	_{1.59s (± 0.74%)}	_{+0.00s (+ 0.13%)}	_1.57s	_1.63s
_{Bind Time}	_{0.72s (± 0.50%)}	_{0.73s (± 0.65%)}	_{+0.00s (+ 0.41%)}	_0.72s	_0.74s
_{Check Time}	_{5.71s (± 0.29%)}	_{5.73s (± 0.43%)}	_{+0.02s (+ 0.44%)}	_5.67s	_5.78s
_{Emit Time}	_{3.35s (± 0.66%)}	_{3.40s (± 0.98%)}	_{+0.05s (+ 1.40%)}	_3.36s	_3.52s
_{Total Time}	_{11.37s (± 0.26%)}	_{11.45s (± 0.44%)}	_{+0.07s (+ 0.66%)}	_11.37s	_11.61s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,671k (± 0.00%)}	_{289,673k (± 0.00%)}	_{+2k (+ 0.00%)}	_289,662k	_289,707k
_{Parse Time}	_{1.30s (± 0.89%)}	_{1.30s (± 0.84%)}	_{-0.00s (- 0.15%)}	_1.29s	_1.34s
_{Bind Time}	_{0.79s (± 2.33%)}	_{0.80s (± 0.43%)}	_{+0.00s (+ 0.63%)}	_0.79s	_0.80s
_{Check Time}	_{5.37s (± 0.53%)}	_{5.36s (± 0.45%)}	_{-0.02s (- 0.32%)}	_5.30s	_5.40s
_{Emit Time}	_{3.62s (± 1.05%)}	_{3.61s (± 0.94%)}	_{-0.01s (- 0.19%)}	_3.53s	_3.69s
_{Total Time}	_{11.08s (± 0.50%)}	_{11.07s (± 0.44%)}	_{-0.02s (- 0.14%)}	_10.94s	_11.15s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,657k (± 0.00%)}	_{436,669k (± 0.00%)}	_{+12k (+ 0.00%)}	_436,619k	_436,718k
_{Parse Time}	_{1.88s (± 0.49%)}	_{1.88s (± 1.00%)}	_{-0.01s (- 0.32%)}	_1.86s	_1.94s
_{Bind Time}	_{0.59s (± 0.81%)}	_{0.58s (± 1.02%)}	_{-0.00s (- 0.34%)}	_0.57s	_0.60s
_{Check Time}	_{12.96s (± 0.70%)}	_{12.86s (± 0.54%)}	_{-0.10s (- 0.80%)}	_12.73s	_12.98s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.43s (± 0.58%)}	_{15.32s (± 0.50%)}	_{-0.11s (- 0.72%)}	_15.20s	_15.49s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,150k (± 0.00%)}	_{547,179k (± 0.00%)}	_{+29k (+ 0.01%)}	_547,161k	_547,209k
_{Parse Time}	_{2.63s (± 0.69%)}	_{2.64s (± 0.48%)}	_{+0.01s (+ 0.42%)}	_2.61s	_2.67s
_{Bind Time}	_{0.98s (± 1.23%)}	_{0.98s (± 1.23%)}	_{-0.00s (- 0.00%)}	_0.96s	_1.01s
_{Check Time}	_{1.52s (± 0.59%)}	_{1.52s (± 0.65%)}	_{-0.01s (- 0.46%)}	_1.50s	_1.54s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 3.14%)}	_{+0.00s (+ 1.43%)}	_0.07s	_0.08s
_{Total Time}	_{5.22s (± 0.46%)}	_{5.22s (± 0.26%)}	_{+0.00s (+ 0.02%)}	_5.20s	_5.26s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₂₆	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

DanielRosenwasser · 2022-09-20T20:15:34Z

I think the perf test looks fine. I think we're good to merge!

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 3, 2022

a-tarasyuk force-pushed the feat/49962 branch from d85fc01 to a51aa40 Compare September 3, 2022 16:41

feat(49962): disallow comparison against NaN

ec857a9

a-tarasyuk force-pushed the feat/49962 branch from a51aa40 to ec857a9 Compare September 3, 2022 17:18

DanielRosenwasser reviewed Sep 12, 2022

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

change diagnostic message

fb44a1d

a-tarasyuk force-pushed the feat/49962 branch from bd22ca6 to fb44a1d Compare September 14, 2022 07:30

a-tarasyuk requested a review from DanielRosenwasser September 14, 2022 07:31

DanielRosenwasser reviewed Sep 14, 2022

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

use global NaN symbol for NaN equality comparisons

5ca49bb

a-tarasyuk requested a review from DanielRosenwasser September 15, 2022 06:25

DanielRosenwasser approved these changes Sep 16, 2022

View reviewed changes

DanielRosenwasser requested review from navya9singh and weswigham September 16, 2022 00:37

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

89c00e6

…eat/49962

weswigham approved these changes Sep 20, 2022

View reviewed changes

DanielRosenwasser merged commit e002159 into microsoft:main Sep 20, 2022

github-actions bot mentioned this pull request Dec 18, 2022

Rename property in ts 4.9 satisfies section microsoft/TypeScript-Website-Localizations#194

Merged

nevedaren mentioned this pull request Feb 16, 2023

Extend "no comparison with NaN" check to cover "Number.NaN" #52780

Open

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

a-tarasyuk commented Sep 3, 2022

Uh oh!

Uh oh!

DanielRosenwasser commented Sep 14, 2022

Uh oh!

typescript-bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 14, 2022

Uh oh!

typescript-bot commented Sep 14, 2022

Uh oh!

Uh oh!

typescript-bot commented Sep 15, 2022

Uh oh!

DanielRosenwasser commented Sep 16, 2022

Uh oh!

typescript-bot commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Sep 16, 2022

Uh oh!

DanielRosenwasser commented Sep 20, 2022

Uh oh!

a-tarasyuk commented Sep 20, 2022

Uh oh!

weswigham commented Sep 20, 2022

Uh oh!

typescript-bot commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2022

Uh oh!

DanielRosenwasser commented Sep 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Sep 14, 2022 •

edited

Loading

typescript-bot commented Sep 14, 2022 •

edited

Loading

typescript-bot commented Sep 14, 2022 •

edited

Loading

typescript-bot commented Sep 14, 2022 •

edited

Loading

typescript-bot commented Sep 16, 2022 •

edited

Loading

typescript-bot commented Sep 20, 2022 •

edited

Loading