Bump version to 5.1, fix 'ignoreDeprecations', and update baselines.#52975
Merged
DanielRosenwasser merged 1 commit intomainfrom Feb 27, 2023
Merged
Bump version to 5.1, fix 'ignoreDeprecations', and update baselines.#52975DanielRosenwasser merged 1 commit intomainfrom
DanielRosenwasser merged 1 commit intomainfrom
Conversation
jakebailey
approved these changes
Feb 27, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
I'm going to LGTM this so we can get 5.1 rolling, but, I'm pretty sure this deprecation code is not functioning correctly before or after the change for any version that isn't 5.0 or below. I'll see if I can clean this up into something that I think makes more sense but that can come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.