fix: remove-display-table for mobile device#2840
Merged
jakebailey merged 2 commits intomicrosoft:v2from Jun 5, 2023
Merged
Conversation
jakebailey
added
the
deploy-preview
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2840.centralus.azurestaticapps.net |
jakebailey
requested changes
May 31, 2023
Member
There was a problem hiding this comment.
Comparing the live site with this PR, this breaks the table when there is enough space:
- https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#interfaces
- https://delightful-glacier-09aa73710-2840.centralus.azurestaticapps.net/docs/handbook/2/everyday-types.html#interfaces
Now:
This PR:
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2840.centralus.azurestaticapps.net |
Contributor
Author
|
@jakebailey |
jakebailey
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I reading typescript handbook with tablet PC, I found that part of document is hidden in tablet PC screen.
To fix this I remove 'display: table' property from 'table.full-width-table'
table.full-width-table selector is used in 2 pages. (one of them is deprecated)
and after removing property, it works well.