Merged
Conversation
Added functionality to internal\tools\uvmboot for LCOW: * specifying boot file path; * picking kernel or vmlinux file; * mounting SCSI VHDS and sharing files into the uVM; * disabling the time sync; * setting the uVM security policy. Added `IsElevated() bool` function to `internal/winapi` to quite early if the command is not run with admin privileges rather than returning a cryptic error. This is to support testing and benchmarking the Linux GCS. Signed-off-by: Hamza El-Saawy <[email protected]>
Contributor
|
LCOW gets all the love :). This is cool |
anmaxvl
reviewed
Apr 22, 2022
Signed-off-by: Hamza El-Saawy <[email protected]>
anmaxvl
approved these changes
Apr 22, 2022
dcantah
reviewed
Apr 26, 2022
internal/winapi/elevation.go
Outdated
| "golang.org/x/sys/windows" | ||
| ) | ||
|
|
||
| func IsEvelated() bool { |
Contributor
There was a problem hiding this comment.
Suggested change
| func IsEvelated() bool { | |
| func IsElevated() bool { |
dcantah
approved these changes
Apr 26, 2022
Signed-off-by: Hamza El-Saawy <[email protected]>
3 tasks
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* uvmboot functionality Added functionality to internal\tools\uvmboot for LCOW: * specifying boot file path; * picking kernel or vmlinux file; * mounting SCSI VHDS and sharing files into the uVM; * disabling the time sync; * setting the uVM security policy. Added `IsElevated() bool` function to `internal/winapi` to quite early if the command is not run with admin privileges rather than returning a cryptic error. This is to support testing and benchmarking the Linux GCS. Signed-off-by: Hamza El-Saawy <[email protected]> * PR: math Signed-off-by: Hamza El-Saawy <[email protected]> * PR: spelling Signed-off-by: Hamza El-Saawy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to internal\tools\uvmboot for LCOW:
Added
IsElevated() boolfunction tointernal/winapito quit earlyif the command is not run with admin privileges rather than returning a
cryptic error.
This is to support testing and benchmarking the Linux GCS.
Signed-off-by: Hamza El-Saawy [email protected]