Readonly option for hostprocess mounts#1462
Merged
dcantah merged 1 commit intomicrosoft:mainfrom Aug 27, 2022
Merged
Conversation
helsaawy
approved these changes
Jul 20, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
It feels weird to change the meaning of a parameter, but it looks like its only used a handful of times....
Contributor
Author
The wonders of /internal APIs lol If we ever plop this package in go-winio maybe we just have the third param just take in a uint32 and you can specify the flags. Right now only readonly makes sense for us at least. |
Add in ability to parse read only mount options for hostprocess mounts. Change the API of ApplyFileBinding to take in a readOnly bool instead of it signifying a merged binding. We don't have any use for merged bindings as the default for containers is to shadow the directory we're binding to. We could alternatively pass in a set of options/flags as this argument, but readonly seems to be the only thing needed as of now. Signed-off-by: Daniel Canter <[email protected]>
kiashok
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in ability to parse read only mount options for hostprocess mounts.
Change the API of ApplyFileBinding to take in a readOnly bool instead of
it signifying a merged binding. We don't have any use for merged bindings
as the default for containers is to shadow the directory we're binding
to. We could alternatively pass in a set of options/flags as this argument,
but readonly seems to be the only thing needed as of now.