Closed
Conversation
|
|
Author
|
@jterry75 @jhowardmsft let me know if you want this and i'll sign the cla or push with my docker address as we probably already have a company one. |
Contributor
|
I personally am ok with vendoring here but I will leave this up to @jhowardmsft he knows this repo best |
Contributor
|
I think this makes sense, but I'll talk it over with @jstarks when he's back from PTO next week. |
Contributor
|
@crosbymichael - You can remove the 2nd commit. We fixed the go-winio build issue |
Signed-off-by: Michael Crosby <[email protected]>
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Remove VHDX booting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This vendors the hcsshim dependencies so that consistent builds can be produced.