HCS: Remove not anymore needed CGO dependency#749
Merged
jterry75 merged 2 commits intomicrosoft:masterfrom Jan 9, 2020
Merged
Conversation
With golang/go@bb0fae6 this also works without CGO (>=Go 1.11).
Contributor
|
@kevpar - PTAL |
Contributor
|
Hey can you also remove the mingw addition from the path in the appveyor.yml LGTM! |
jterry75
approved these changes
Jan 7, 2020
Contributor
|
@kevpar - I did verify this is fine and passes all tests as well |
|
|
Contributor
Author
|
@jterry75 Done. |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
HCS: Remove not anymore needed CGO dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With golang/go@bb0fae6 this also
works without CGO (>=Go 1.11).