Create a correctly-sized slice to proxy *uint16#926
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Jan 22, 2021
Merged
Conversation
TBBle
force-pushed
the
convert-pointer-to-slice-without-failing-checkptr
branch
5 times, most recently
from
b00e2d2 to
fe51c0e
Compare
Contributor
Author
|
If the change in CI stack version is undesirable, I can back that out, once CI passes. As a less-disruptive alternative we could also roll back to 1.13, and turn on |
Fixes the below issue seen in the containerd test suite. ``` fatal error: checkptr: converted pointer straddles multiple allocations ``` Also adds `-gcflags=all=-d=checkptr` to all the test runs on CI, to avoid this regressing in future. This requires testing with Go 1.14 or newer, so CI now runs on Go 1.15, as Go 1.14 did not recommend using checkptr on Windows. And _that_ requires the Visual Studio 2019 build image on AppVeyor. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
force-pushed
the
convert-pointer-to-slice-without-failing-checkptr
branch
from
fe51c0e to
0bb6d5c
Compare
|
Is the use of |
Contributor
Author
|
I'm not sure if there's a preference there or not. This was the minimal change to reproduce the problem. Also, I didn't know it was implicit in |
|
Yeah I'd prefer to not add back |
dcantah
approved these changes
Jan 21, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the below issue seen in the containerd test suite.
Also adds
-gcflags=all=-d=checkptrto all the test runs on CI, to avoid this regressing in future. This requires testing with Go 1.14 or newer, so CI now runs on Go 1.15, as Go 1.14 did not recommend using checkptr on Windows.And Go>1.13 requires the Visual Studio 2019 build image on AppVeyor.