Create upper and work directories in new locations if sharing scratch#929
Create upper and work directories in new locations if sharing scratch#929dcantah merged 1 commit intomicrosoft:masterfrom
Conversation
| testDeviceInstanceID, err := findTestNvidiaGPUDevice() | ||
| if err != nil { | ||
| t.Fatalf("skipping test, failed to find assignable nvidia gpu on host with: %v", err) | ||
| t.Skipf("skipping test, failed to find assignable nvidia gpu on host with: %v", err) |
There was a problem hiding this comment.
I don't think this was intentional was it?
There was a problem hiding this comment.
It was, shouldn't we be doing what it says in the description and skipping instead of failing the test?
There was a problem hiding this comment.
No, these were changed specifically to Fatal since we now use features to determine what tests to run, so these would only be run intentionally. In which case, they should fail if the machine doesn't have the correct resources.
It sounds like instead the comments should be updated to reflect that. But either way, that should be done in a separate PR.
There was a problem hiding this comment.
Ok gotcha the comment was tripping me up. I'll revert these!
There was a problem hiding this comment.
I ended up fixing some of the ones that actually were Skip, and just changed ones that didn't have any formatting needed to just Fatal from Fatalf
Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
new-overlay-path
branch
from
888f1e0 to
9c9b92a
Compare
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
3 participants
Signed-off-by: Daniel Canter [email protected]