go.mod: update various dependencies#941
Closed
thaJeztah wants to merge 7 commits intomicrosoft:masterfrom
Closed
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: sirupsen/logrus@v1.4.2...v1.7.0 logrus v1.7.0 removes dependency on github.com/konsorten/go-windows-terminal-sequences Features: * a new buffer pool management API has been added * a set of `<LogLevel>Fn()` functions have been added Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The go.mod specified the commit instead of the tag Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Contributor
Author
|
Hmmm... something's failing; Wondering if this is because of the override in the |
Contributor
|
@thaJeztah I assume this: #942 is to fix the CI issue you're mentioning? |
Contributor
Author
|
@dcantah I'm not sure it fixes the issue, but at least looked like something that wasn't correct currently. I was planning to update both modules separately (the "test" module is a separate module, so I didn't want to modify both in the same PR), but when trying to update the hcsshim "main module" dependency there, I ran into issues because the go-winio dependency has some windows-only packages, and apparently go mod doesn't deal with that when not on Windows 😣 |
Contributor
Author
|
I opened microsoft/go-winio#193 to (hopefully) fix the |
|
Looks like between containerd v1.3.2 and v1.4.x there was a change that added code to use |
Contributor
Author
|
Obsoleted by #946, which also updated these dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details