Make directory creation deterministic#943
Merged
kevpar merged 1 commit intomicrosoft:masterfrom Feb 9, 2021
SeanTAllen:deterministic-directories
Merged
Make directory creation deterministic#943kevpar merged 1 commit intomicrosoft:masterfrom SeanTAllen:deterministic-directories
kevpar merged 1 commit intomicrosoft:masterfrom
SeanTAllen:deterministic-directories
Conversation
Prior to this commit, the layout of created ext4 filesystems created using tar2ext4 wasn't deterministic. Recursive directory creation would change from run to run due to the usage of a map as temporary storage for items from the tar stream. This commit changes recursive directory creation to follow the same deterministic pattern as writeDirectory. At this point, the only possible source of non-determinism in a create file system is the UUID in the VHD footer. If no VHD footer is included, then the results are deterministic.
anmaxvl
approved these changes
Feb 8, 2021
dcantah
approved these changes
Feb 9, 2021
Contributor
|
@SeanTAllen Were you going to change the UUID generation also in another PR? What's the plan for this, a hash? |
Contributor
Author
|
I believe that is still a topic for conversation. I will do in another PR once a decision is made. |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the layout of created ext4 filesystems created using tar2ext4 wasn't
deterministic. Recursive directory creation would change from run to run due to the usage
of a map as temporary storage for items from the tar stream.
This commit changes recursive directory creation to follow the same deterministic pattern
as writeDirectory.
At this point, the only possible source of non-determinism in a create file system is the
UUID in the VHD footer. If no VHD footer is included, then the results are deterministic.